Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files

org/ninjasoft/macpackager/AntMacPackager.java

Error		Line
	Missing a header - not enough lines in file.	1
	Using the '.*' form of import should be avoided - java.io.*.	19
	Using the '.*' form of import should be avoided - java.util.*.	20
	Using the '.*' form of import should be avoided - org.apache.tools.ant.*.	21
	Line has trailing spaces.	27
	Line is longer than 80 characters.	33
	Line has trailing spaces.	35
	Line has trailing spaces.	37
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Variable 'filesets' must be private and have accessor methods.	42
	Line has trailing spaces.	43
	Missing a Javadoc comment.	44
	';' is followed by whitespace.	45
	'for' construct must use '{}'s.	51
	'=' is not preceded with whitespace.	51
	'=' is not followed by whitespace.	51
	'<' is not preceded with whitespace.	51
	'<' is not followed by whitespace.	51
	Line has trailing spaces.	55
	Method 'execute' is not designed for extension - needs to be abstract, final or empty.	56
	Missing a Javadoc comment.	56
	Redundant throws: 'BuildException' is unchecked exception.	56
	'try' is not followed by whitespace.	59
	'{' is not preceded with whitespace.	59
	Line contains a tab character.	60
	'catch' is not preceded with whitespace.	61
	'}' is not followed by whitespace.	61
	'catch' is not followed by whitespace.	61
	'{' is not preceded with whitespace.	61
	Line has trailing spaces.	65
	Method 'addFileset' is not designed for extension - needs to be abstract, final or empty.	68
	Missing a Javadoc comment.	68
	Parameter fileset should be final.	68
	Line has trailing spaces.	71
	Line contains a tab character.	72
	Method 'setIcon' is not designed for extension - needs to be abstract, final or empty.	72
	Missing a Javadoc comment.	72
	Parameter icon should be final.	72
	Line contains a tab character.	74
	Line contains a tab character.	75
	Method 'setInfoString' is not designed for extension - needs to be abstract, final or empty.	75
	Missing a Javadoc comment.	75
	Parameter infoString should be final.	75
	Line contains a tab character.	77
	Line contains a tab character.	78
	Method 'setMainClass' is not designed for extension - needs to be abstract, final or empty.	78
	Missing a Javadoc comment.	78
	Parameter mainClass should be final.	78
	Line contains a tab character.	80
	Line contains a tab character.	81
	Method 'setVersion' is not designed for extension - needs to be abstract, final or empty.	81
	Missing a Javadoc comment.	81
	Parameter version should be final.	81
	Line contains a tab character.	83
	Line contains a tab character.	84
	Method 'setVmOptions' is not designed for extension - needs to be abstract, final or empty.	84
	Missing a Javadoc comment.	84
	Parameter vmOptions should be final.	84
	Line contains a tab character.	86
	Line contains a tab character.	87
	Method 'setAppName' is not designed for extension - needs to be abstract, final or empty.	87
	Missing a Javadoc comment.	87
	Parameter appName should be final.	87
	Line contains a tab character.	89

org/ninjasoft/macpackager/InfoBuilder.java

Error		Line
	Missing a header - not enough lines in file.	1
	Using the '.*' form of import should be avoided - java.io.*.	19
	Using the '.*' form of import should be avoided - java.util.*.	20
	Missing a Javadoc comment.	29
	Missing a Javadoc comment.	30
	Missing a Javadoc comment.	31
	Missing a Javadoc comment.	32
	Missing a Javadoc comment.	33
	Missing a Javadoc comment.	34
	Missing a Javadoc comment.	35
	Line has trailing spaces.	36
	Line has trailing spaces.	37
	Missing a Javadoc comment.	37
	Line has trailing spaces.	38
	'+' should be on a new line.	38
	Line is longer than 80 characters.	39
	'+' should be on a new line.	39
	'+' should be on a new line.	40
	'+' should be on a new line.	41
	'+' should be on a new line.	42
	'+' should be on a new line.	43
	'+' should be on a new line.	44
	'+' should be on a new line.	45
	'+' should be on a new line.	46
	'+' should be on a new line.	47
	'+' should be on a new line.	48
	'+' should be on a new line.	49
	'+' should be on a new line.	50
	'+' should be on a new line.	51
	'+' should be on a new line.	52
	'+' should be on a new line.	53
	'+' should be on a new line.	54
	'+' should be on a new line.	55
	'+' should be on a new line.	56
	'+' should be on a new line.	57
	'+' should be on a new line.	58
	'+' should be on a new line.	59
	'+' should be on a new line.	60
	'+' should be on a new line.	61
	'+' should be on a new line.	62
	'+' should be on a new line.	63
	'+' should be on a new line.	64
	'+' should be on a new line.	65
	'+' should be on a new line.	66
	'+' should be on a new line.	67
	'+' should be on a new line.	68
	'+' should be on a new line.	69
	'+' should be on a new line.	70
	'+' should be on a new line.	71
	'+' should be on a new line.	72
	'+' should be on a new line.	73
	'+' should be on a new line.	74
	'+' should be on a new line.	75
	Line has trailing spaces.	76
	'+' should be on a new line.	76
	'+' should be on a new line.	77
	'+' should be on a new line.	78
	'+' should be on a new line.	79
	'+' should be on a new line.	80
	'+' should be on a new line.	81
	'+' should be on a new line.	82
	'+' should be on a new line.	83
	'+' should be on a new line.	84
	Line has trailing spaces.	86
	Method 'getXml' is not designed for extension - needs to be abstract, final or empty.	87
	Missing a Javadoc comment.	87
	'=' is not preceded with whitespace.	91
	'=' is not followed by whitespace.	91
	'<' is not preceded with whitespace.	91
	'<' is not followed by whitespace.	91
	'==' is not preceded with whitespace.	98
	'==' is not followed by whitespace.	98
	'==' is not preceded with whitespace.	100
	'==' is not followed by whitespace.	100
	'==' is not preceded with whitespace.	102
	'==' is not followed by whitespace.	102
	'==' is not preceded with whitespace.	104
	'==' is not followed by whitespace.	104
	'==' is not preceded with whitespace.	106
	'==' is not followed by whitespace.	106
	'==' is not preceded with whitespace.	108
	'==' is not followed by whitespace.	108
	'==' is not preceded with whitespace.	110
	'==' is not followed by whitespace.	110
	';' is followed by whitespace.	111
	Line has trailing spaces.	122
	Missing a Javadoc comment.	123
	Line has trailing spaces.	126
	Line contains a tab character.	129
	Line contains a tab character.	130
	Line contains a tab character.	131
	Line contains a tab character.	132
	Method 'getBundleName' is not designed for extension - needs to be abstract, final or empty.	132
	Line contains a tab character.	133
	Line contains a tab character.	134
	Line contains a tab character.	135
	Line contains a tab character.	136
	Line contains a tab character.	137
	Line contains a tab character.	138
	Method 'setBundleName' is not designed for extension - needs to be abstract, final or empty.	138
	Parameter bundleName should be final.	138
	'bundleName' hides a field.	138
	Line contains a tab character.	139
	Line contains a tab character.	140
	Line contains a tab character.	141
	Line contains a tab character.	142
	Line contains a tab character.	143
	Line contains a tab character.	144
	Method 'getInfoString' is not designed for extension - needs to be abstract, final or empty.	144
	Line contains a tab character.	145
	Line contains a tab character.	146
	Line contains a tab character.	147
	Line contains a tab character.	148
	Line contains a tab character.	149
	Line contains a tab character.	150
	Method 'setInfoString' is not designed for extension - needs to be abstract, final or empty.	150
	Parameter infoString should be final.	150
	'infoString' hides a field.	150
	Line contains a tab character.	151
	Line contains a tab character.	152
	Line contains a tab character.	153
	Unused @param tag for 'jarFiles'.	154
	Line contains a tab character.	154
	Line contains a tab character.	155
	Line contains a tab character.	156
	Method 'addJarFile' is not designed for extension - needs to be abstract, final or empty.	156
	Parameter filename should be final.	156
	Expected @param tag for 'filename'.	156
	Line contains a tab character.	159
	Line contains a tab character.	160
	Line contains a tab character.	161
	Line contains a tab character.	162
	Line contains a tab character.	163
	Method 'getMainClass' is not designed for extension - needs to be abstract, final or empty.	163
	Line contains a tab character.	164
	Line contains a tab character.	165
	Line contains a tab character.	166
	Line contains a tab character.	167
	Line contains a tab character.	168
	Line contains a tab character.	169
	Method 'setMainClass' is not designed for extension - needs to be abstract, final or empty.	169
	Parameter mainClass should be final.	169
	'mainClass' hides a field.	169
	Line contains a tab character.	170
	Line contains a tab character.	171
	Line contains a tab character.	172
	Line contains a tab character.	173
	Line contains a tab character.	174
	Line contains a tab character.	175
	Method 'getVersion' is not designed for extension - needs to be abstract, final or empty.	175
	Line contains a tab character.	176
	Line contains a tab character.	177
	Line contains a tab character.	178
	Line contains a tab character.	179
	Line contains a tab character.	180
	Line contains a tab character.	181
	Method 'setVersion' is not designed for extension - needs to be abstract, final or empty.	181
	Parameter version should be final.	181
	'version' hides a field.	181
	Line contains a tab character.	182
	Line contains a tab character.	183
	Line contains a tab character.	184
	Line contains a tab character.	185
	Line contains a tab character.	186
	Line contains a tab character.	187
	Method 'getVmOptions' is not designed for extension - needs to be abstract, final or empty.	187
	Line contains a tab character.	188
	Line contains a tab character.	189
	Line contains a tab character.	190
	Line contains a tab character.	191
	Line contains a tab character.	192
	Line contains a tab character.	193
	Method 'setVmOptions' is not designed for extension - needs to be abstract, final or empty.	193
	Parameter vmOptions should be final.	193
	'vmOptions' hides a field.	193
	Line contains a tab character.	194
	Line contains a tab character.	195

org/ninjasoft/macpackager/MacPackager.java

Error		Line
	Missing a header - not enough lines in file.	1
	Using the '.*' form of import should be avoided - java.io.*.	19
	Using the '.*' form of import should be avoided - java.util.*.	20
	Line has trailing spaces.	25
	Line is longer than 80 characters.	30
	Line has trailing spaces.	32
	Line has trailing spaces.	34
	Missing a Javadoc comment.	38
	Missing a Javadoc comment.	39
	Missing a Javadoc comment.	40
	Missing a Javadoc comment.	41
	Missing a Javadoc comment.	42
	Missing a Javadoc comment.	43
	Line has trailing spaces.	44
	Missing a Javadoc comment.	45
	Missing a Javadoc comment.	46
	Missing a Javadoc comment.	47
	Line has trailing spaces.	48
	Missing a Javadoc comment.	50
	Name 'appExt' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.	50
	Line has trailing spaces.	51
	Method 'buildApplication' is not designed for extension - needs to be abstract, final or empty.	52
	Missing a Javadoc comment.	52
	'for' construct must use '{}'s.	61
	';' is followed by whitespace.	61
	Line contains a tab character.	62
	Line contains a tab character.	66
	'if' construct must use '{}'s.	68
	Line has trailing spaces.	80
	Missing a Javadoc comment.	81
	Parameter s should be final.	81
	'if' construct must use '{}'s.	82
	Array brackets at illegal position.	86
	'for' construct must use '{}'s.	87
	'=' is not preceded with whitespace.	87
	'=' is not followed by whitespace.	87
	'<' is not preceded with whitespace.	87
	'<' is not followed by whitespace.	87
	Line has trailing spaces.	94
	First sentence should end with a period.	95
	Expected @throws tag for 'PackageException'.	99
	'if' construct must use '{}'s.	102
	Line is longer than 80 characters.	103
	'if' construct must use '{}'s.	105
	Line is longer than 80 characters.	106
	Line has trailing spaces.	108
	Missing a Javadoc comment.	109
	Line is longer than 80 characters.	111
	Line is longer than 80 characters.	112
	Line contains a tab character.	113
	'try' is not followed by whitespace.	120
	'{' is not preceded with whitespace.	120
	'if' construct must use '{}'s.	123
	Line is longer than 80 characters.	124
	'catch' is not preceded with whitespace.	125
	'}' is not followed by whitespace.	125
	'catch' is not followed by whitespace.	125
	'{' is not preceded with whitespace.	125
	Line is longer than 80 characters.	126
	'catch' is not preceded with whitespace.	127
	'}' is not followed by whitespace.	127
	'catch' is not followed by whitespace.	127
	'{' is not preceded with whitespace.	127
	Line is longer than 80 characters.	128
	Line is longer than 80 characters.	132
	';' is followed by whitespace.	135
	Line is longer than 80 characters.	137
	Line has trailing spaces.	141
	Missing a Javadoc comment.	142
	'try' is not followed by whitespace.	143
	'{' is not preceded with whitespace.	143
	Line is longer than 80 characters.	144
	'catch' is not preceded with whitespace.	148
	'}' is not followed by whitespace.	148
	'catch' is not followed by whitespace.	148
	'{' is not preceded with whitespace.	148
	Line is longer than 80 characters.	149
	'try' is not followed by whitespace.	151
	'{' is not preceded with whitespace.	151
	Line is longer than 80 characters.	152
	'catch' is not preceded with whitespace.	156
	'}' is not followed by whitespace.	156
	'catch' is not followed by whitespace.	156
	'{' is not preceded with whitespace.	156
	Line is longer than 80 characters.	157
	Line has trailing spaces.	159
	Line has trailing spaces.	161
	First sentence should end with a period.	162
	Parameter source should be final.	168
	Expected @param tag for 'source'.	168
	Parameter destination should be final.	168
	Expected @param tag for 'destination'.	168
	Expected @throws tag for 'PackageException'.	168
	'try' is not followed by whitespace.	169
	'{' is not preceded with whitespace.	169
	'1024' is a magic number.	172
	'while' construct must use '{}'s.	174
	'catch' is not preceded with whitespace.	178
	'}' is not followed by whitespace.	178
	'catch' is not followed by whitespace.	178
	'{' is not preceded with whitespace.	178
	Line is longer than 80 characters.	179
	Line has trailing spaces.	182
	First sentence should end with a period.	183
	Expected @throws tag for 'PackageException'.	187
	'try' is not followed by whitespace.	195
	'{' is not preceded with whitespace.	195
	'if' construct must use '{}'s.	198
	Line is longer than 80 characters.	199
	'catch' is not preceded with whitespace.	200
	'}' is not followed by whitespace.	200
	'catch' is not followed by whitespace.	200
	'{' is not preceded with whitespace.	200
	Line is longer than 80 characters.	201
	'catch' is not preceded with whitespace.	202
	'}' is not followed by whitespace.	202
	'catch' is not followed by whitespace.	202
	'{' is not preceded with whitespace.	202
	Line is longer than 80 characters.	203
	Line has trailing spaces.	206
	Line is longer than 80 characters.	208
	Line has trailing spaces.	210
	Method 'validate' is not designed for extension - needs to be abstract, final or empty.	213
	Expected @throws tag for 'PackageException'.	213
	'if' construct must use '{}'s.	214
	Line is longer than 80 characters.	214
	'if' construct must use '{}'s.	215
	Line is longer than 80 characters.	215
	'if' construct must use '{}'s.	216
	Line is longer than 80 characters.	216
	'if' construct must use '{}'s.	217
	Line is longer than 80 characters.	217
	'if' construct must use '{}'s.	218
	'if' construct must use '{}'s.	219
	Line is longer than 80 characters.	219
	'if' construct must use '{}'s.	220
	Line is longer than 80 characters.	220
	'if' construct must use '{}'s.	222
	'if' construct must use '{}'s.	225
	'if' construct must use '{}'s.	228
	Line is longer than 80 characters.	229
	Line has trailing spaces.	231
	Method 'addJar' is not designed for extension - needs to be abstract, final or empty.	234
	Missing a Javadoc comment.	234
	Parameter jar should be final.	234
	Line has trailing spaces.	237
	Line contains a tab character.	238
	Method 'setIcon' is not designed for extension - needs to be abstract, final or empty.	238
	Missing a Javadoc comment.	238
	Parameter icon should be final.	238
	'icon' hides a field.	238
	Line contains a tab character.	239
	Line contains a tab character.	240
	Line contains a tab character.	241
	Method 'setInfoString' is not designed for extension - needs to be abstract, final or empty.	241
	Missing a Javadoc comment.	241
	Parameter infoString should be final.	241
	'infoString' hides a field.	241
	Line contains a tab character.	242
	Line contains a tab character.	243
	Line contains a tab character.	244
	Method 'setMainClass' is not designed for extension - needs to be abstract, final or empty.	244
	Missing a Javadoc comment.	244
	Parameter mainClass should be final.	244
	'mainClass' hides a field.	244
	Line contains a tab character.	245
	Line contains a tab character.	246
	Line contains a tab character.	247
	Method 'setVersion' is not designed for extension - needs to be abstract, final or empty.	247
	Missing a Javadoc comment.	247
	Parameter version should be final.	247
	'version' hides a field.	247
	Line contains a tab character.	248
	Line contains a tab character.	249
	Line contains a tab character.	250
	Method 'setVmOptions' is not designed for extension - needs to be abstract, final or empty.	250
	Missing a Javadoc comment.	250
	Parameter vmOptions should be final.	250
	'vmOptions' hides a field.	250
	Line contains a tab character.	251
	Line contains a tab character.	252
	Line contains a tab character.	253
	Method 'setAppName' is not designed for extension - needs to be abstract, final or empty.	253
	Missing a Javadoc comment.	253
	Parameter appName should be final.	253
	'appName' hides a field.	253
	Line contains a tab character.	254
	Line contains a tab character.	255

org/ninjasoft/macpackager/MavenAntPackager.java

Error		Line
	Missing a header - not enough lines in file.	1
	Missing a Javadoc comment.	26
	Line has trailing spaces.	27
	Method 'execute' is not designed for extension - needs to be abstract, final or empty.	28
	Missing a Javadoc comment.	28
	Line has trailing spaces.	31
	Line has trailing spaces.	32
	Method 'setJars' is not designed for extension - needs to be abstract, final or empty.	35
	Missing a Javadoc comment.	35
	Parameter path should be final.	35
	'if' construct must use '{}'s.	39
	Method 'addJar' is not designed for extension - needs to be abstract, final or empty.	43
	Missing a Javadoc comment.	43
	Parameter filename should be final.	43
	Method 'setIcon' is not designed for extension - needs to be abstract, final or empty.	46
	Missing a Javadoc comment.	46
	Parameter icon should be final.	46
	Method 'setInfoString' is not designed for extension - needs to be abstract, final or empty.	49
	Missing a Javadoc comment.	49
	Parameter infoString should be final.	49
	Method 'setMainClass' is not designed for extension - needs to be abstract, final or empty.	52
	Missing a Javadoc comment.	52
	Parameter mainClass should be final.	52
	Method 'setVersion' is not designed for extension - needs to be abstract, final or empty.	55
	Missing a Javadoc comment.	55
	Parameter version should be final.	55
	Method 'setVmOptions' is not designed for extension - needs to be abstract, final or empty.	58
	Missing a Javadoc comment.	58
	Parameter vmOptions should be final.	58
	Method 'setAppName' is not designed for extension - needs to be abstract, final or empty.	61
	Missing a Javadoc comment.	61
	Parameter appName should be final.	61

org/ninjasoft/macpackager/PackageException.java

Error		Line
	Missing a header - not enough lines in file.	1
	First sentence should end with a period.	19
	Missing a Javadoc comment.	24
	Parameter s should be final.	24

org/ninjasoft/macpackager/package.html

Error		Line
	Missing package documentation file.	0